[codex] Add DCA runtime settings#183
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 926147103d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| dca_mode=_optional_dca_mode_env("DCA_MODE"), | ||
| dca_base_investment_usd=_optional_positive_float_env("DCA_BASE_INVESTMENT_USD"), |
There was a problem hiding this comment.
When these new DCA_MODE / DCA_BASE_INVESTMENT_USD settings are configured as GitHub environment variables and the standard .github/workflows/sync-cloud-run-env.yml workflow is used, they are never passed to Cloud Run: the workflow's optional override env block currently only exposes the income vars at lines 156-161, and the update/remove block only syncs those income vars at lines 934-955. As a result the new fields remain None in managed deployments unless operators manually edit the Cloud Run service outside the repo workflow, so the DCA runtime controls added here have no effect in the normal deployment path.
Useful? React with 👍 / 👎.
1 participant
Summary
Validation
Note